Skip to content

CDRIVER-4362 Add showExpandedEvents option for C2C replication #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 25, 2022
Merged

CDRIVER-4362 Add showExpandedEvents option for C2C replication #1133

merged 12 commits into from
Oct 25, 2022

Conversation

galon1
Copy link
Contributor

@galon1 galon1 commented Oct 24, 2022 •
edited
Loading

Support for the showExpandedEvents option is added, following the spec changes in this ticket. A new test was added following this PR. No new changes were needed for the new changeStream events, but the dropIndex which was added to the test runner.

Note: In order for the tests to pass this PR will also merge the fix listed in CDRIVER-4464

@galon1 galon1 requested a review from kevinAlbs October 24, 2022 13:46
kevinAlbs
kevinAlbs reviewed Oct 24, 2022
View reviewed changes
vector-of-bool
vector-of-bool approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galon1 galon1 requested a review from kevinAlbs October 24, 2022 20:12
kevinAlbs
kevinAlbs approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with running python ./build/generate-opts.py to regenerate the option documentation.

@galon1 galon1 merged commit 0c32afe into mongodb:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@vector-of-bool vector-of-bool vector-of-bool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galon1 @kevinAlbs @vector-of-bool