CDRIVER-4505 Fix build on MacOS due to undeclared getpagesize #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that getpagesize has been deprecated on newer MacOS versions. We can see that POSIX version 7 (link below) has removed getpagesize altogether from the standard, so even including unistd.h does not solve this problem on newer MacOS versions. Please see here at section B.3.2 System Interfaces Removed in the Previous Version: https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap03.html Relevant stackoverflow: https://stackoverflow.com/a/37193970
kevinAlbs
changed the title
kevinAlbs
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Nice, LGTM! When merging, include "CDRIVER-4505" in the commit message. That will result in a comment being added to the Jira ticket.
kevinAlbs
pushed a commit
that referenced
this pull request
Jan 3, 2023
Fix build on MacOS due to undeclared getpagesize CDRIVER-4505 It appears that getpagesize has been deprecated on newer MacOS versions. We can see that POSIX version 7 (link below) has removed getpagesize altogether from the standard, so even including unistd.h does not solve this problem on newer MacOS versions. Please see here at section B.3.2 System Interfaces Removed in the Previous Version: https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap03.html Relevant stackoverflow: https://stackoverflow.com/a/37193970 Jira: https://jira.mongodb.org/browse/CDRIVER-4505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDRIVER-4505
It appears that getpagesize has been deprecated on newer MacOS versions. We can see that POSIX version 7 (link below) has removed getpagesize altogether from the standard, so even including unistd.h does not solve this problem on newer MacOS versions.
Please see here at section B.3.2 System Interfaces Removed in the Previous Version:
https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap03.html
Relevant stackoverflow:
https://stackoverflow.com/a/37193970
Jira:
https://jira.mongodb.org/browse/CDRIVER-4505