CDRIVER-4136 Use C99 as default C standard without requiring explicit CMake config variables #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to CDRIVER-4136 and is a followup to #1067.
Explicit CMake config variables
CMAKE_C_STANDARD,CMAKE_C_STANDARD_REQUIRED, andCMAKE_C_EXTENSIONSthat were required by #1067 are now set by default during CMake configuration unless otherwise directed (e.g. passing-DCMAKE_C_STANDARD=11during CMake configuration). This means the C Driver will now implicitly default to conforming to a minimum C standard (currently C99).Note: The variables are deliberately set as normal variables, not cache variables, to avoid influencing the state of parent CMake projects that may
add_subdirectory()the C Driver, notably libmongocrypt.Changes verified by this patch.