-
Notifications
You must be signed in to change notification settings - Fork 455
CDRIVER-4435 Add support for GCP service accounts in GCP KMS #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested, some about consolidating with Azure KMS work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Before merging this PR, please run an Evergreen patch build with the two new tasks. The two new tasks are not run by default.
That can be done with:
evergreen patch --project=mongo-c-driver --description="Test GCP $(git log --oneline HEAD~1..HEAD)" \
--yes --finalize \
-v testgcpkms-variant -t testgcpkms-task \
-v testgcpkms-variant -t testgcpkms-fail-task
Summary:
gcp: {}
, create agcp_service_account_token
by sending a HTTP request to the GCP metadata server. Most of these changes are modeled after how azure tokens were added.service-gcp.c
which uses a mock GCP server to test the code handles different HTTP responses. This test uses thefake_azure.py
mock server..evergreen/config.yml
to spin up a remote GCE instance using the scripts indrivers-evergreen-tools
(link to github). Here is a patch build with the new GCP KMS tasks.Notes:
the files listed below were copied from this PR since they will be added late, but are needed for integration testing.
Most recent patch build with the new tasks can be found here: https://spruce.mongodb.com/version/6363fa95d1fe076083e2114f/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC