Skip to content

CDRIVER-4480 Do not connect to mongocryptd if shared library is loaded #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 28, 2022

Conversation

galon1
Copy link
Contributor

@galon1 galon1 commented Nov 15, 2022

The C driver already does not connect to mongocrypted if the shared library is loaded. So the only changes was to add the new prose test described here.

@galon1 galon1 requested a review from kevinAlbs November 15, 2022 19:06
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions to reduce test duration. Nicely done.

Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galon1 galon1 merged commit e507fc9 into mongodb:master Nov 28, 2022
@galon1 galon1 deleted the CDRIVER-4480 branch November 28, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants