CDRIVER-4394 Add explicit encryption support and tests for range indexes #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galon1
changed the title
Let libmongocrypt do the error checking
Matches public API docs
Destroying is not necessary for primitive types like int/double. But prevents a leak if a heap allocated types (e.g. string) is passed.
Produces a consistent error if range_opts are unset for both explicit helpers
It is not required by callers
There is no need to yet. Once there is a stable version of libmongocrypt 1.7.0, will bump the dependency.
kevinAlbs
requested review from
kkloberdanz and
vector-of-bool
and removed request for
kevinAlbs
kkloberdanz
reviewed
Dec 19, 2022
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
I suggest that we have newline characters at the end of files.
kkloberdanz
reviewed
Dec 19, 2022
| static ree_fixture * | ||
| range_explicit_encryption_setup (const char *typeStr) | ||
| { | ||
| ree_fixture *reef = (ree_fixture *) bson_malloc0 (sizeof (ree_fixture)); |
There was a problem hiding this comment.
In C, casting from void * is not necessary, so I suggest that we don't cast on malloc. Reasoning can be found here: https://stackoverflow.com/a/605858
kkloberdanz
reviewed
Dec 19, 2022
| test_range_explicit_encryption_case3 (void *ctx) | ||
| { | ||
| // Case 3: can find encrypted range and return the minimum | ||
| const char *typeStr = (const char *) ctx; |
There was a problem hiding this comment.
Casting from void * is not necessary, so I suggest we remove the cast.
kkloberdanz
reviewed
Dec 19, 2022
| test_range_explicit_encryption_case4 (void *ctx) | ||
| { | ||
| // Case 4: can find encrypted range with an open range query | ||
| const char *typeStr = (const char *) ctx; |
There was a problem hiding this comment.
Casting from void * is not necessary, so I suggest we remove the cast.
kkloberdanz
approved these changes
Dec 19, 2022
vector-of-bool
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for explicit encryption with the Range Index.
mongoc_client_encryption_encrypt_range_optsand pass to libmongocrypt.mongoc_client_encryption_encrypt_expression.ASSERT_BSONVALUE_EQ.Background & Motivation
See mongodb/specifications@4de4e3c for a description of the API change and prose tests.
Range Index requires MongoDB server 6.2+.
The API is marked experimental due to this comment.