CDRIVER-4519 Replace activate_venv.sh with new hygienic scripts #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Dec 2, 2022
| # TODO: remove this function along with the "run kms servers" function. | ||
| . ./activate_venv.sh | ||
| deactivate | ||
| if [[ "$OSTYPE" =~ cygwin && ! -d kmstlsvenv ]]; then |
There was a problem hiding this comment.
Have you tried using the py launcher to select a specific version? I believe it is installed with Windows Python by default.
There was a problem hiding this comment.
TIL, I was not aware of the py launcher. It seems like it is available on all the Windows distros we currently use (only exception is windows-2022 which we do not currently use). However, given the purpose here is simply to behave as a distro-specific workaround, I do not think there is an advantage to using py here. It might be worth considering for the find-python3.sh DET script.
kevinAlbs
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves CDRIVER-4519. Verified by this patch.
The proposed changes are a straightforward substitution of the old
activate_venv.shscripts for kmstslvenv and authawsvenv with the exception of Python selection behavior on Windows.CDRIVER-4530 was created in response to issues with default cipher suite incompatibilities on Windows due to use of Python 3.10. A crude but simple workaround was applied that explicitly uses Python 3.9 (windows-2017) or Python 3.8 (windows-2015) instead, as addressing the root problem (upgrading certificates to use a better signature algorithm) required an unexpectedly significant amount of effort. See CDRIVER-4530 for more info.