Kyle/snapshot example 2 #1156
Merged
Kyle/snapshot example 2 #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
requested review from
vector-of-bool
and removed request for
galon1
kevinAlbs
approved these changes
Dec 5, 2022
| bson_iter_t iter; | ||
| int64_t total_sales = 0; | ||
|
|
||
| client = test_framework_new_default_client (); |
There was a problem hiding this comment.
I suggest constructing client outside of the example comments. test_framework_new_default_client is not a public API function.
I missed this before. Please also update test_example_59.
|
My mistake, I jumped the gun on merging this in before @vector-of-bool could add his review. I can re-open if you have any suggestions. |
|
No trouble. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDRIVER-4295
Implement snapshot query example number two for the manual.
Related: DRIVERS-2181