Skip to content

CDRIVER-4146 Add live server version 3.6 condition to /retryable_writes/legacy tests #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2022
Merged

CDRIVER-4146 Add live server version 3.6 condition to /retryable_writes/legacy tests #1160

merged 1 commit into from
Dec 13, 2022

Conversation

eramongodb
Copy link
Contributor

Resolves CDRIVER-4146. Verified by this patch.

test_framework_skip_if_max_wire_version_less_than_6 was chosen to comply with the Retryable Writes Tests spec:

Tests will require a MongoClient created with options defined in the tests. Integration tests will require a running MongoDB cluster with server versions 3.6.0 or later.

@eramongodb eramongodb requested a review from kevinAlbs December 13, 2022 16:31
@eramongodb eramongodb self-assigned this Dec 13, 2022
@eramongodb
Copy link
Contributor Author

The patch is riddled with unrelated test failures due to /http POST request timeouts, but confirmed the MinGW tasks such as debug-compile-sspi-winssl are no longer failing due to /retryable_writes/legacy tests (they are now failing due to /speculative_auth/request_scram instead). 😐

@eramongodb eramongodb merged commit 766a8a3 into mongodb:master Dec 13, 2022
@eramongodb eramongodb deleted the cdriver-4146 branch December 13, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees

@eramongodb eramongodb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eramongodb @kevinAlbs