Use httpbin.org instead of example.com for /http tests #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Dec 13, 2022
Comment on lines
41
to
48
| ASSERT_WITH_MSG (res.status == 200, | ||
| "unexpected status code %d\n" | ||
| "RESPONSE BODY BEGIN\n" | ||
| "%s" | ||
| "RESPONSE BODY END\n", | ||
| res.status, | ||
| res.body_len > 0 ? res.body : ""); | ||
| ASSERT_OR_PRINT (r, error); |
There was a problem hiding this comment.
Suggested change
| ASSERT_WITH_MSG (res.status == 200, | |
| "unexpected status code %d\n" | |
| "RESPONSE BODY BEGIN\n" | |
| "%s" | |
| "RESPONSE BODY END\n", | |
| res.status, | |
| res.body_len > 0 ? res.body : ""); | |
| ASSERT_OR_PRINT (r, error); | |
| ASSERT_OR_PRINT (r, error); | |
| ASSERT_WITH_MSG (res.status == 200, | |
| "unexpected status code %d\n" | |
| "RESPONSE BODY BEGIN\n" | |
| "%s" | |
| "RESPONSE BODY END\n", | |
| res.status, | |
| res.body_len > 0 ? res.body : ""); |
Suggest checking for an error first. An error in socket connection may result in res.status being 0. The error may have more useful information.
Comment on lines
72
to
79
| ASSERT_WITH_MSG (res.status == 200, | ||
| "unexpected status code %d\n" | ||
| "RESPONSE BODY BEGIN\n" | ||
| "%s" | ||
| "RESPONSE BODY END\n", | ||
| res.status, | ||
| res.body_len > 0 ? res.body : ""); | ||
| ASSERT_OR_PRINT (r, error); |
There was a problem hiding this comment.
Suggested change
| ASSERT_WITH_MSG (res.status == 200, | |
| "unexpected status code %d\n" | |
| "RESPONSE BODY BEGIN\n" | |
| "%s" | |
| "RESPONSE BODY END\n", | |
| res.status, | |
| res.body_len > 0 ? res.body : ""); | |
| ASSERT_OR_PRINT (r, error); | |
| ASSERT_OR_PRINT (r, error); | |
| ASSERT_WITH_MSG (res.status == 200, | |
| "unexpected status code %d\n" | |
| "RESPONSE BODY BEGIN\n" | |
| "%s" | |
| "RESPONSE BODY END\n", | |
| res.status, | |
| res.body_len > 0 ? res.body : ""); |
kevinAlbs
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CDRIVER-4538. Verified by this patch.
The
/httptest has been split into/http/getand/http/postand useshttpbin.orginstead ofexample.org.As a drive-by fix, this PR also resolves CDRIVER-4537 by ensure calls to
abort()in the test suite are preceeded by bothfflush (stdout)andfflush (stderr)to improve the quality of test output on failures.