[CDRIVER-4540] Define a success test for CreateEncryptedCollection #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates an encrypted collection using the CEC API, then uses the generated key to encrypt a value, and then inserts that value into the new encrypted collection. Expects success.
kkloberdanz
approved these changes
Jan 12, 2023
eramongodb
approved these changes
Jan 12, 2023
Comment on lines
+6436
to
+6439
| mongoc_collection_drop (coll, &error); | ||
| bool okay = | ||
| error.code == 0 || strstr (error.message, "ns not found") != NULL; | ||
| ASSERT_OR_PRINT (okay, error); |
There was a problem hiding this comment.
Can this just be (void)mongoc_collection_drop(...); as done in some other tests?
There was a problem hiding this comment.
Potentially, but any error other than "ns not found" will indicate that the remainder of the test will likely also fail.
| bson_value_t plain; | ||
| plain.value_type = BSON_TYPE_UTF8; | ||
| plain.value.v_utf8.str = "123-45-6789"; | ||
| plain.value.v_utf8.len = strlen (plain.value.v_utf8.str); |
There was a problem hiding this comment.
Suggested change
| plain.value.v_utf8.len = strlen (plain.value.v_utf8.str); | |
| plain.value.v_utf8.len = (uint32_t) strlen (plain.value.v_utf8.str); |
Address -Wshorten-64-to-32 warnings.
| visitEach (require (type (doc)), | ||
| parse (require (key ("keyId"), | ||
| require (type (binary)), | ||
| do({ |
There was a problem hiding this comment.
Suggested change
| do({ | |
| do ({ |
ClangFormat.
There was a problem hiding this comment.
This appears to be a behavior change in Clang 16 :(
kevinAlbs
approved these changes
Jan 12, 2023
Co-authored-by: Kevin Albertson <[email protected]>
Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an encrypted collection using the CEC API, then uses the generated key to encrypt a value, and then inserts that value into the new encrypted collection. Expects success.