-
Notifications
You must be signed in to change notification settings - Fork 455
CDRIVER-4439 add AWS credential cache #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
065a1b0
add test-awsauth
kevinAlbs c22bdf6
unconditionally define _mongoc_aws_credentials_cleanup
kevinAlbs 90524db
add AWS credential cache
kevinAlbs 3f2cdc9
use AWS credential cache
kevinAlbs 2a185e2
use test-awsauth in Evergreen
kevinAlbs 6776f34
remove outdated docs of optional variables
kevinAlbs 6ceae5c
fix docs to note TESTCASE is an env var
kevinAlbs d1624d5
remove unnecessary additions runtime paths
kevinAlbs 1b93a95
use `mcd_timer` for expiration
kevinAlbs d9b8d8e
remove unused vars
kevinAlbs 21d8491
simplify bash scripts
kevinAlbs c5a9dea
fix comment for `expiration`
kevinAlbs 6c8f40f
be more explicit about _mongoc_aws_credentials_cache_get behavior
kevinAlbs dad4cf5
rename helper to expiration_to_mcd_timer
kevinAlbs 922e2c3
compute in int64_t domain
kevinAlbs e2fa0ac
remove unnecessary expiration vars
kevinAlbs 1c6c266
add MONGOC_AWS_CREDENTIALS_INIT macro
kevinAlbs 0c9b872
only initialize and cleanup AWS cache if AWS is enabled
kevinAlbs 34a024d
remove unnecessary can_setenv
kevinAlbs 9664419
fix -Wmissing-braces warning
kevinAlbs 59fa557
fix signature of test_aws_cache
kevinAlbs bc2f59b
do not support uninitialized creds in _mongoc_aws_credentials_cache_get
kevinAlbs 154d6c7
do not reuse creds after cleanup
kevinAlbs a6a75c1
fix -Wmissing-field-initializers warning
kevinAlbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is more conventional to have the
dest
parameter first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to keep as is. The
src, dst
order is consistent with all other C driver functions named*_copy_to
.