CDRIVER-4580 Move compile-test coverage from macos-1014 to macos-1100 #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest changes verified by this patch. |
kevinAlbs
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Nice, LGTM. I suggest leaving CDRIVER-4580 in the Backlog status with the fixVersion 1.24.0. I intended that ticket include the communication to drop macOS 10.14 in the 1.24.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves CDRIVER-4580 and CDRIVER-3483. Verified by this patch.
Compile tasks were added/left-in for macos-1014 and macos-1015 in the
sasl.darwinssl.COMPILE_MATRIXas the C Driver still documents their support. However, macos-1015 compile is disabled due to MONGOCRYPT-443 (assumed to be related due to absence of<Security/Security.h>required bymongoc-stream-tls-secure-transport-private.h). These compile tasks may be removed if preferable.These changes only apply to components defined by the new config generator. Most tasks defined by the legacy config generator still use macos-1014 (i.e. several
link-with-*tasks and some tasks in the OCSP and Darwin variants). These may also be updated to use macos-1100 if preferable.ENABLE_ZSTD=OFFworkarounds related to CDRIVER-3483 were removed, as the issues regarding inconsistent availability of ZSTD libraries was specific to macos-1014 and do not seem to be present on macos-1100. See related discussion in BUILD-16814 which motivated this PR.add_expansions_to_env: truewas removed fromrun-mock-kms-serversas some CFLAGS being defined for libmongoc compilation were interfering with compilation of some Python packages during package installation. The function did not actually require any expansions to behave correctly.The scan_build matrix in #1205 will also need to be updated to use macos-1100 instead of macos-1014 once merged.