Skip to content

Update /scram/auth_tests to handle SCRAM-SHA-256 error messages #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

eramongodb
Copy link
Contributor

Verified by this patch.

Several tasks on Evergreen are currently failing due to an unexpected error message in /scram/auth_tests that does not satisfy the expected substring search:

src/libmongoc/tests/test-mongoc-scram.c:295 _check_error(): [Unable to use SCRAM-SHA-256 based authentication for user without any SCRAM-SHA-256 credentials registered] does not contain [Authentication failed]

It is unclear why the error message has changed. This PR simply proposes modifying the test to account for new error message in its expected output.

@eramongodb eramongodb requested a review from kevinAlbs February 24, 2023 17:39
@eramongodb eramongodb self-assigned this Feb 24, 2023
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test fix.

@eramongodb eramongodb merged commit c0b4391 into mongodb:master Feb 24, 2023
@eramongodb eramongodb deleted the cdriver-scram branch February 24, 2023 18:58
@Neustradamus
Copy link

@eramongodb: Good job!

Linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants