Disable retryable handshakes by default for mock server tests #1214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been several mock server tests since #1141 was merged that required manually disabling retryable handshakes to maintain correct test behavior (i.e. expectations that a single mock server hangup request should trigger progress). This PR removes those workarounds in favor of setting
retryReads=false
andretryWrites=false
by default in the URI returned bymock_server_get_uri
andmock_rs_get_uri
. Mock server tests that actually require retryable handshakes are thus appropriately limited totest-mongoc-retryable-reads.c
andtest-mongoc-retryable-writes.c
whereretryReads=true
orretryWrites=true
is explicitly set as needed.