Skip to content

Disable retryable handshakes by default for mock server tests #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Mar 9, 2023

There have been several mock server tests since #1141 was merged that required manually disabling retryable handshakes to maintain correct test behavior (i.e. expectations that a single mock server hangup request should trigger progress). This PR removes those workarounds in favor of setting retryReads=false and retryWrites=false by default in the URI returned by mock_server_get_uri and mock_rs_get_uri. Mock server tests that actually require retryable handshakes are thus appropriately limited to test-mongoc-retryable-reads.c and test-mongoc-retryable-writes.c where retryReads=true or retryWrites=true is explicitly set as needed.

@eramongodb eramongodb requested a review from kevinAlbs March 9, 2023 16:50
@eramongodb eramongodb self-assigned this Mar 9, 2023
@eramongodb eramongodb merged commit d44babf into mongodb:master Mar 9, 2023
@eramongodb eramongodb deleted the cdriver-mock-server branch March 9, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants