Skip to content

CDRIVER-4590 don't call ERR_load_BIO_strings for OpenSSL 3.0+ #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2023
Merged

CDRIVER-4590 don't call ERR_load_BIO_strings for OpenSSL 3.0+ #1216

merged 2 commits into from
Mar 16, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 13, 2023

https://jira.mongodb.org/browse/CDRIVER-4590

OpenSSL 3.0 loads error strings automatically and deprecated this function.

@jmikola
CDRIVER-4590 don't call ERR_load_BIO_strings for OpenSSL 3.0+
13cb002 
OpenSSL 3.0 loads error strings automatically and deprecated this function.
@jmikola jmikola requested a review from eramongodb March 15, 2023 08:10
@eramongodb
Copy link
Contributor

Confirmed, documented in the 3.0 migration guide under "deprecated function mappings":

ERR_load_*(), ERR_func_error_string(), ERR_get_error_line(), ERR_get_error_line_data(), ERR_get_state(): OpenSSL now loads error strings automatically so these functions are not needed.

eramongodb
eramongodb approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback; otherwise LGTM.

@jmikola jmikola merged commit 72cba00 into mongodb:master Mar 16, 2023
@jmikola jmikola deleted the cdriver-4590 branch March 16, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @eramongodb