CDRIVER-4593: Handle double type connectionId #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
kevinAlbs
approved these changes
Mar 27, 2023
eramongodb
approved these changes
Mar 27, 2023
kevinAlbs
added a commit
that referenced
this pull request
Mar 27, 2023
* CDRIVER-4593: Handle double type connectionId * use scopes in test_server_description_connection_id * use cleanup instead of reset * use ASSERT_CMPINT64 * add test for double --------- Co-authored-by: Kevin Albertson <[email protected]>
jmikola
reviewed
Mar 28, 2023
| memset (&error, 0, sizeof (bson_error_t)); | ||
| mongoc_server_description_handle_hello (&sd, hello, 0 /* rtt */, &error); | ||
| BSON_ASSERT (sd.type == MONGOC_SERVER_STANDALONE); | ||
| BSON_ASSERT (sd.server_connection_id == 1); |
There was a problem hiding this comment.
I think this should have used ASSERT_CMPINT64 since libmongoc still stores the value as an int64_t; however, it probably makes little difference in practice.
There was a problem hiding this comment.
Agreed. PR posted: #1223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change validates the Int32, Int64 and Double type connectionId from the hello or ismater response from mongo. We see C-Drivers(1.23.1 & 1.23.2) are fail to connect mongo because of type check failure for double type connectionId. Please refer CDRIVER-4593 for more details.