CDRIVER-4610 add separate min/max setters #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
approved these changes
Apr 19, 2023
jmikola
approved these changes
Apr 20, 2023
|
Filed CXX-2681 for C++ driver changes. |
Yup, no need for a new PHPC ticket. I'll link the existing ticket up with CDRIVER-4610. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mongoc_client_encryption_encrypt_range_opts_set_min_maxwithmongoc_client_encryption_encrypt_range_opts_set_minandmongoc_client_encryption_encrypt_range_opts_set_max.Verified with this patch build: https://spruce.mongodb.com/version/64400ea6c9ec44a4c343f75e
Background & Motivation
There is no reason to include min and max in the same setter. libmongocrypt is expected to validate constraints on options. This has the benefit of not requiring driver changes if libmongocrypt relaxes constraints in the future.