CDRIVER-4557 add int64 connection_id functions
#1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
connection_id functions
kkloberdanz
approved these changes
Apr 25, 2023
eramongodb
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
connection_idfunctions returning int64:mongoc_apm_command_started_get_server_connection_id_int64mongoc_apm_command_succeeded_get_server_connection_id_int64mongoc_apm_command_failed_get_server_connection_id_int64connection_idfunctions returning int32Background & Motivation
CDRIVER-4593 and CDRIVER-4502 applied fixes to parsing
connectionIdto handleint32,int64, anddouble. No further fix was needed.This PR intends to satisfy the requirement of DRIVERS-2503: