Skip to content

CDRIVER-4556 Remove use of collStats #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 28, 2023
Merged

CDRIVER-4556 Remove use of collStats #1249

merged 12 commits into from
Apr 28, 2023

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Apr 27, 2023 •
edited
Loading

Summary

  • Remove use of collStats

Background & Motivation

From DRIVERS-2232:

For drivers that have helpers for collStats or currentOp, the helpers should be adjusted to use the $collStats / $currentOp aggregation pipeline stages. Alternatively, drivers can deprecate these helpers for future removal. This is left to the discretion of drivers.

mongoc_collection_stats is already deprecated. Examples using mongoc_collection_stats were updated to use aggregation with the $collStats pipeline stage. There is no helper for currentOp.

Example code was moved from .rst files into the examples directory and included with the literalinclude directive. This is intended to have the examples compile in Evergreen.

The runCommand Example 2 example, which used collStats, was removed. This example was added for the documentation team in DRIVERS-448. DOCSP-21320 requests removing runCommand Example 2 from documentation.

kevinAlbs added 11 commits April 26, 2023 15:38
@kevinAlbs
sync specification tests to commit 6632b7606e74c6e83ee2d80b7571f55485…
752c98e 
…c7ff33
@kevinAlbs
remove runCommand Example 2
f596aa9 
The example removed from DRIVERS-448.
@kevinAlbs
suggest $collStats in mongoc_collection_stats
e894955
@kevinAlbs
move example in mongoc_collection_command_simple to example source
d7e4335
@kevinAlbs
add missing declaration of str
4449028
@kevinAlbs
use ping instead of collStats command
c3f7e84
@kevinAlbs
move Executing Commands code to example
7858bf0
@kevinAlbs
replace collStats with ping
c569f5c
@kevinAlbs
use mongoc_client_command_simple
d58c8ff 
To simplify the example.
There is no need to run the command with the mongoc_collection_t handle.
@kevinAlbs
remove note about returning cursors
9400467 
`mongoc_collection_command`, `mongoc_database_command` and `mongoc_client_command` return a cursor. They are documented as `superseded` by other helpers.
@kevinAlbs
skip test using collStats on servers > 6.0
6296792
@kevinAlbs kevinAlbs marked this pull request as ready for review April 27, 2023 19:38
eramongodb
eramongodb approved these changes Apr 27, 2023
View reviewed changes
@kevinAlbs @eramongodb
remove redundant captions
f3fd88f 
Co-authored-by: Ezra Chung <[email protected]>
vector-of-bool
vector-of-bool approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was unaware of the start-after and end-before options. Very useful!

@kevinAlbs kevinAlbs merged commit 2d27a11 into mongodb:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vector-of-bool vector-of-bool vector-of-bool approved these changes

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinAlbs @vector-of-bool @eramongodb