Skip to content

CDRIVER-4621 Replace codecov-bash with new Codecov Uploader #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2023

Conversation

eramongodb
Copy link
Contributor

Description

Resolves CDRIVER-4621. Verified by this patch.

Replaced the deprecated codecov-bash command with the new Codecov Uploader. Also applied verbosity-reduction filters to reduce the output of code coverage commands.

Fixes and Improvements

Fixed the coverage task so it actually compiles with CSE enabled before running CSE tests. The coverage task currently skips most of the CSE tests it's supposed to run due to CSE being disabled, producing an abysmal coverage report. 🥴

Added test-coverage-latest-replica-set-auth-sasl-openssl to account for the -cse task limiting tests to CSE tests only (since #1201).

Removed -DENABLE_CLIENT_SIDE_ENCRYPTION=ON in EXTRA_CONFIGURE_FLAGS for CSE tasks, as it is automatically set when COMPILE_LIBMONGOCRYPT=ON in compile-*.sh.

Updated Codecov filters to ignore kms-message (vendored), zlib (bundled), and test code (do not test the tests).

@eramongodb eramongodb requested a review from kevinAlbs May 3, 2023 19:45
@eramongodb eramongodb self-assigned this May 3, 2023
@eramongodb eramongodb merged commit 89717a3 into mongodb:master May 3, 2023
@eramongodb eramongodb deleted the cdriver-4621 branch May 3, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants