Skip to content

CDRIVER-4316 Allow both int32 and int64 for batchSize in cursor opts #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

adriandole
Copy link
Contributor

Description

The server allows batchSize to be either int32 or int64. This should also be allowed in the cursor.

@adriandole adriandole marked this pull request as ready for review June 9, 2023 16:47
@adriandole adriandole requested a review from kevinAlbs June 9, 2023 16:47
@kevinAlbs kevinAlbs requested a review from eramongodb June 9, 2023 16:48
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and comments to consider, but otherwise, LGTM.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with pending comments addressed.

@adriandole adriandole requested a review from eramongodb June 13, 2023 17:28
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unused variables and a missing warning; otherwise, LGTM.

@adriandole adriandole merged commit 986316c into mongodb:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants