Skip to content

CDRIVER-4617 Remove legacy mongoc-rpc entities #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2023
Merged

CDRIVER-4617 Remove legacy mongoc-rpc entities #1312

merged 1 commit into from
Jun 26, 2023

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Jun 16, 2023 •
edited
Loading

Followup to #1307. Finally resolves CDRIVER-4617 by removing old mongoc_rpc_t code that is now no longer being used, as it has been entirely replaced by mcd_rpc_message code.

@eramongodb eramongodb self-assigned this Jun 16, 2023
kevinAlbs
kevinAlbs approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfying. LGTM

vector-of-bool
vector-of-bool approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien

@eramongodb eramongodb merged commit 8126cd3 into mongodb:master Jun 26, 2023
@eramongodb eramongodb deleted the cdriver-4617 branch June 26, 2023 18:36
@kevinAlbs kevinAlbs mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@vector-of-bool vector-of-bool vector-of-bool approved these changes

Assignees

@eramongodb eramongodb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eramongodb @kevinAlbs @vector-of-bool