Skip to content

CDRIVER-3969 set serverId with mocked cursor reply #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

CDRIVER-3969 set serverId with mocked cursor reply #1335

merged 1 commit into from
Jul 3, 2023

Conversation

kevinAlbs
Copy link
Collaborator

Summary

  • Set serverId with cursor reply in mock server tests.

Patch build: https://spruce.mongodb.com/version/64a31761d6d80a59abafb6fa

Background & Motivation

This is a follow-up to #1321 intended to fix the mock-server-test task.

Some mock server tests were not updated in #1321 resulting in test failures in the mock-server-test task (example):

[2023/06/30 19:34:11.873] FAIL:/data/mci/9db2b61a88bd7d9576782354fa709a71/mongoc/src/libmongoc/tests/test-mongoc-cursor.c:1126  test_cursor_new_tailable_await()
[2023/06/30 19:34:11.873]   !mongoc_cursor_error (cursor, &error)
[2023/06/30 19:34:11.873]   Expected `serverId` option to identify server with open cursor (cursor ID is 123). Consider using `mongoc_client_select_server` and using the resulting server ID to create the cursor.

@kevinAlbs
CDRIVER-3969 set serverId with mocked cursor reply
9d0b8cb 
serverId is expected in mongoc_cursor_new_from_command_reply_with_opts
when the reply includes a non-zero cursor.id
@kevinAlbs kevinAlbs marked this pull request as ready for review July 3, 2023 18:58
joshbsiegel
joshbsiegel approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@joshbsiegel joshbsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 9e7bf88 into mongodb:master Jul 3, 2023
kevinAlbs added a commit that referenced this pull request Jul 11, 2023
@kevinAlbs
CDRIVER-3969 set serverId with mocked cursor reply (#1335)
e167ae7 
serverId is expected in mongoc_cursor_new_from_command_reply_with_opts
when the reply includes a non-zero cursor.id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriandole adriandole adriandole approved these changes

@joshbsiegel joshbsiegel joshbsiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinAlbs @adriandole @joshbsiegel