CDRIVER-2928 assert returned values of bson_init_static
#1351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbsiegel
reviewed
Jul 20, 2023
Good catch. Done. |
joshbsiegel
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bson_init_staticBackground & Motivation
Addresses Coverity issues with CIDs: 134030, 134029, 120108, and 120107.
The test macro
ASSERTwas used in test code.BSON_ASSERTwas used in driver code.bson_init_staticreturns false on failure. Failure may occur if the input BSON data is invalid. Callers ignoring the returned value have been updated to assert to result in an early error on invalid BSON data input.