CDRIVER-4493 Override host platform, os, flags, compiler info for testing #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jul 25, 2023
| ASSERT (BSON_ITER_HOLDS_UTF8 (&inner_iter)); | ||
| val = bson_iter_utf8 (&inner_iter, NULL); | ||
| _check_os_version_valid (val); | ||
| } |
There was a problem hiding this comment.
Since _override_host_platform_os is used to avoid truncation, can version or architecture be assumed to exist? If so, suggest reverting the added if checks to improve test coverage.
This reverts commit eef539c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in
test-mongo-handshake.cexpect that the handshake doc is not truncated, causing failures with some test hosts with a long platform string. This PR overrides host info for testing.