CDRIVER-4698 remove excess duplicate call #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a bug. The duplicate call to `_mongoc_http_response_cleanup` does not currently result in a double free. Nonetheless, the duplicate call may result in a double free if the implementation of `_mongoc_http_send` changes in the future.
vector-of-bool
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_mongoc_http_response_cleanupBackground & Motivation
Addresses Coverity issues with CIDs: 133796, 133795
This issue was flagged by Coverity as a possible "Double free". But I expect the duplicate call to
_mongoc_http_response_cleanupdoes not result in a double free._mongoc_http_sendzeroes the outputres. Fields inresare set at the end of the call when success is guaranteed.Nonetheless, removing the duplicate call to
_mongoc_http_response_cleanupseems like an improvement. If future changes result in_mongoc_http_sendpossibly failing after setting fields inres, this may result in a double free.