assert return of mcd_rpc_message_to_iovecs
#1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation is expected not to return `NULL`. `BSON_ASSERT` is added for consistency with other calls and to future-proof.
eramongodb
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mcd_rpc_message_to_iovecs.Background & Motivation
Addresses Coverity issue with CID 138246: "Dereference null return value". I do not expect these calls to
mcd_rpc_message_to_iovecsto possibly fail given the current implementation. The addedBSON_ASSERTis consistent with other calls. If future changes tomcd_rpc_message_to_iovecsresult in a condition wheremcd_rpc_message_to_iovecsmay return NULL, this may prevent a NULL dereference.