fix authentication-tests-darwinssl
#1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead: check for presence of `kinit` command. `/etc/krb5.conf` does not appear present on macOS hosts.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
eramongodb
approved these changes
Sep 12, 2023
| @@ -1961,7 +1961,7 @@ tasks: | |||
| - func: bootstrap-mongo-orchestration | |||
| - func: run-mock-kms-servers | |||
| - func: run-tests | |||
| - name: earthly-build-and-test | |||
| - name: earthly-build-check | |||
There was a problem hiding this comment.
Confirming, is the inclusion of this change intentional?
There was a problem hiding this comment.
Yes. I think the Evergreen config was not regenerated after the task was renamed in 6e6546b.
kevinAlbs
added a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace check of existence of
/etc/krb5.confwith presence ofkinitcommand.Fixes failing
authentication-tests-darwinssltask.Changes verified with this patch build: https://spruce.mongodb.com/version/64ff5b602fbabe466a2b35d1/
Background & Summary
The condition in
prepare-kerberoschecked for existence of/etc/krb5.conf:A patch build with more logging showed the
/etc/krb5.conffile does not exist on the macOS host:man kiniton macOS notes the expected default path to be/etc/krb5.conf:It appears not to be necessary to check for the existence of
/etc/krb5.conf.