Skip to content

CDRIVER-4677 conditionally restore AWS instance profile #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 21, 2023

Conversation

kevinAlbs
Copy link
Collaborator

Summary

  • Conditionally restore the AWS instance profile after task

Changes verified with this patch build.

Background & Motivation

The description of DRIVERS-2639 describes the motivation.

Changes were copied and modified from https://github.com/mongodb/mongo-python-driver/pull/1218/files

This is a near copy from mongo-python-driver.

The DRIVERS_TOOLS expansion was replaced with the relative path to drivers-evergreen-tools (DET).

The path to DET is checked since not all C driver tasks call `fetch-det`.
aws_e2e_setup.json is created by the `run aws tests` function.
@kevinAlbs kevinAlbs marked this pull request as ready for review September 20, 2023 20:01
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions; otherwise, LGTM.

@kevinAlbs
Copy link
Collaborator Author

Latest changes tested with patch build.

@kevinAlbs kevinAlbs merged commit 92741f3 into mongodb:master Sep 21, 2023
kevinAlbs added a commit that referenced this pull request Sep 21, 2023
* add `restore-instance-profile` function

---------

Co-authored-by: Ezra Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants