CDRIVER-4353 unskip /server_discovery_and_monitoring/monitoring/heartbeat/pooled/dns
#1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reliably return DNS error
Test expects to fail DNS lookup. Does not require internet.
Destroying the client or pool results in sending `endSessions`. This may result in another heartbeat attempt.
kkloberdanz
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unskip
/server_discovery_and_monitoring/monitoring/heartbeat/pooled/dns.Additional related changes are described in commits.
Changes were tested on this patch with all tasks with names matching
".*test.*. Three repeated runs passed excluding unrelated task failures.Background & Motivation
Similar to changes in #1426, this PR proposes use of the TLD
.invalidintended to reliably return a DNS error. RFC 2606 notes: