CDRIVER-4789 libbson: prevent -Werror=conversion with GCC 12 #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building fails with GCC 12.3:
bson-iter.h:434:33: error: conversion from 'int64_t' {aka 'long long int'} to '__suseconds_t' {aka 'long int'} may change value [-Werror=conversion]
434 | tv->tv_usec = (value % 1000) * 1000;
| ~~~~~~~~~~~~~~~^~~~~~
cc1plus: all warnings being treated as errors
Do the same as with tv->tv_sec, and explicitely cast it to suseconds_t
on non-Win32 systems and to long on Win32.
This matches specificiation in POSIX 2008.
kevinAlbs
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thank you for the PR @rohieb.
Applied c81e4ce to cast the assigned value to tv_sec to time_t to match what is specified in POSIX 2008: https://pubs.opengroup.org/onlinepubs/9699919799.2008edition/
kevinAlbs
changed the title
Ah yes, thanks, looks correct to me! |
adriandole
approved these changes
Nov 28, 2023
kevinAlbs
pushed a commit
that referenced
this pull request
Nov 29, 2023
* libbson: prevent -Werror=conversion with GCC 12
Building fails with GCC 12.3:
bson-iter.h:434:33: error: conversion from 'int64_t' {aka 'long long int'} to '__suseconds_t' {aka 'long int'} may change value [-Werror=conversion]
434 | tv->tv_usec = (value % 1000) * 1000;
| ~~~~~~~~~~~~~~~^~~~~~
cc1plus: all warnings being treated as errors
Do the same as with tv->tv_sec, and explicitely cast it to suseconds_t
on non-Win32 systems and to long on Win32.
* use `time_t` in assignment to `tv_sec`
This matches specificiation in POSIX 2008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on ARM32 fails with GCC 12.3:
Do the same as with tv->tv_sec, and explicitely cast it to suseconds_t on non-Win32 systems and to long on Win32.