Skip to content

CDRIVER-4333 unskip mongohouse tests #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

kevinAlbs
Copy link
Collaborator

Summary

This PR adds test runner behavior changes specific to mongohoused to unskip the the tests described in CDRIVER-4333.

  • Skip running configureFailPoint if testing with mongohoused
  • Skip running drop if testing with mongohoused

Verified with this patch build: https://spruce.mongodb.com/version/65ae70cb850e61cdd0af2591

Background & Motivation

Tests were run with a local instance of mongohoused. Instructions to run mongohoused are described in the drivers-evergreen-tools Atlas Data Lake Testing README.

Running configureFailPoint command results in this error:

Begin /mongohouse/aggregate, seed 976155304
FAIL:/Users/kevin.albertson/code/tasks/mongo-c-driver-CDRIVER-4333/src/libmongoc/tests/json-test.c:1376  deactivate_fail_points()
  r
  command configureFailPoint not found, correlationID = 17abdb65525cb53817152df6

The configureFailPoint is run by the test runner as a precaution to deactivate previously set fail points. The mongohouse tests do not activate fail points.

Running drop results in this error:

FAIL:/Users/kevin.albertson/code/tasks/mongo-c-driver-CDRIVER-4333/src/libmongoc/tests/json-test.c:1014  _recreate()
  error.code == 26
  not authorized: missing privilege for action storageSetConfig on resource __cluster__, correlationID = 17abdc13f48c92a717152e4f

The Atlas Data Lake Testing specification notes:

the test runner for Atlas Data Lake Testing MUST NOT drop the collection and/or database under test.

@kevinAlbs kevinAlbs marked this pull request as ready for review January 22, 2024 13:53
@kevinAlbs kevinAlbs requested a review from rcsanchez97 January 22, 2024 13:53
Copy link
Contributor

@rcsanchez97 rcsanchez97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 283cdc2 into mongodb:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants