Skip to content

CDRIVER-5510 Remove redundant redefinition of BSON_COMPILATION #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

eramongodb
Copy link
Contributor

Resolves CDRIVER-5510. Followup to #1457.

Addresses the preprocessor macro redefinition warning when compiling libbson.rc:

warning RC4005: 'BSON_COMPILATION' : redefinition

@eramongodb eramongodb requested a review from kevinAlbs March 12, 2024 18:54
@eramongodb eramongodb self-assigned this Mar 12, 2024
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix!

@eramongodb eramongodb merged commit 239eddd into mongodb:master Mar 12, 2024
@eramongodb eramongodb deleted the cdriver-5510 branch March 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants