CDRIVER-5536 zero-init bson_iter_t::value
#1587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Zero-initialize
bson_iter_t::value
.This PR is related to, but does not resolve CDRIVER-5536.
Background & Motivation
There are many Coverity issues in the libmongocrypt project referencing uninitialized access of the
bson_iter_t::value
field:I expect this is OK in practice. I do not expect
bson_iter_t::value
is meant to be directly accessed. Thebson_iter_t::value
is initialized and returned inbson_iter_value
. Regardless, this PR errs towards safety. A caller may reasonably expectbson_iter_init
to initialize all struct fields.