CDRIVER-5572 Allow ':' in timezone #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
requested changes
May 15, 2024
There was a problem hiding this comment.
Thank you for the PR! I suggest applying commits from this branch to include a test fix, error message update, and comment.
For added background: I expect this is a bug. The Extended JSON specification references:
ISO-8601 Internet Date/Time Format as described in RFC-3339
It links to https://tools.ietf.org/html/rfc3339#section-5.6 in the footnote. RFC3339 expects a colon:
time-numoffset = ("+" / "-") time-hour ":" time-minute
kevinAlbs
approved these changes
May 16, 2024
kevinAlbs
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not parse "2024-05-13T08:46:14.869+00:00" as date: could not parse timezonestandard ISO8601 4.2.5.2
Basic format: hhmmssthhmm Example: 152746+0100
Extended format: hh:mm:ss+hh:mm Example: 15:27:46+01:00
According to the standard the symbol ':' is acceptable and should even be used