Skip to content

CDRIVER-4618: updated transaction examples #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2024
Merged

CDRIVER-4618: updated transaction examples #1630

merged 2 commits into from
Jun 7, 2024

Conversation

Julia-Garland
Copy link
Contributor

In with_transaction_example:

  • Removed explicit setting of read concern options
  • Removed explicit setting of read preferences
  • Noted that Atlas connection strings include w=majority by default
  • Removed timeout (of 1000ms) from write concern

Made same Atlas default note on line 3642

@Julia-Garland Julia-Garland requested a review from kevinAlbs June 6, 2024 18:08
@Julia-Garland Julia-Garland self-assigned this Jun 6, 2024
@kevinAlbs kevinAlbs requested review from kkloberdanz and removed request for kevinAlbs June 7, 2024 12:57
kkloberdanz
kkloberdanz approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@kkloberdanz kkloberdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Julia-Garland Julia-Garland merged commit c6f0fbc into mongodb:master Jun 7, 2024
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkloberdanz kkloberdanz kkloberdanz approved these changes

Assignees

@Julia-Garland Julia-Garland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julia-Garland @kkloberdanz