CDRIVER-5629 do not use bool in BSON DSL
#1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a drive-by fix. Discovered locally when testing `bool` defined as `int`.
This is a drive-by fix. Discovered locally when testing `bool` defined as `int`.
To address a reported compile issue: https://www.mongodb.com/community/forums/t/error-when-build-mongo-c-driver-with-visual-studio-2019/287062/2 The report suggests `bool` or `_Bool` was `#define`ed to `int`, causing the DSL to evaluate to undefined symbols (e.g. `_bsonDS L_Type_int`, instead of `_bsonDSL_Type_bool`).
kevinAlbs
changed the title
bool in BSON DSLbool in BSON DSL
vector-of-bool
approved these changes
Jul 8, 2024
kevinAlbs
added a commit
that referenced
this pull request
Jul 10, 2024
* fix usage of `drop_target` bool in test * use correct return type in test * update BSON DSL to use `boolean`, rather than `bool` To address a reported compile issue: https://www.mongodb.com/community/forums/t/error-when-build-mongo-c-driver-with-visual-studio-2019/287062/2 The report suggests `bool` or `_Bool` was `#define`ed to `int`, causing the DSL to evaluate to undefined symbols (e.g. `_bsonDSL_Type_int`, instead of `_bsonDSL_Type_bool`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
boolin BSON DSL withboolean.Evergreen patch: https://spruce.mongodb.com/version/668c26d644a2bb0007db5a0f
Background & Motivation
Intended to avoid possible build errors when
boolis defined as a macro. This forum post suggests the user's build environment definesbool(or_Bool) asint, resulting in a build error due to BSON DSL macros evaluating to an undeclared identifier:To reproduce the reported issue, a
stdbool.hwas added locally to defineboolasint:In the process of testing, other misuse of
boolvariables in tests were discovered and addressed as drive-by fixes.