remove extra artifact from release-archive
#1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report is already included in the release tarball
vector-of-bool
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM, but do we yet have confirmation on whether the report files need to be submitted to the shared SSDLC folder for every release?
If "yes", then I recommend adding such details to the release instructions, as well as where those files are located within the release archive.
If "no", then this is fine as-is.
Not yet. No response yet in slack thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes to the release process:
distdirectory. The report is already included in the release tarball.ssldc=>ssdlc.