CDRIVER-5636 make trimFactor and sparsity optional
#1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
eramongodb
requested changes
Jul 24, 2024
src/libmongoc/doc/mongoc_client_encryption_encrypt_range_opts_set_sparsity.rst
Outdated
Show resolved
Hide resolved
src/libmongoc/doc/mongoc_client_encryption_encrypt_range_opts_set_trim_factor.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Ezra Chung <[email protected]>
eramongodb
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sparsityandtrimFactoras optional.sparsityandtrimFactorto libmongocrypt if set.Evergreen patch: https://spruce.mongodb.com/version/669eb9a3c96e7f000700497c
Background & Motivation
MONGOCRYPT-698 changes libmongocrypt to make
trimFactorandsparsityoptional. If not set, they default to values matching the server.This PR includes tests proposed in DRIVERS-2927.
Prior to this PR,
trimFactorandsparsitywere only passed to libmongocrypt if set to a non-zero value. However, atrimFactorof 0 is a accepted value by libmongocrypt.sparsityof 0 results in an error in libmongocrypt.