Skip to content

CDRIVER-5645 skip auth tests running against MongoDB 3.6. #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

kevinAlbs
Copy link
Collaborator

Summary

Skip authentication tests running against 3.6 servers.

Verified by this patch

Background & Motivation

CDRIVER-4815 dropped support for 3.6 servers. Some test servers are running 3.6, resulting in task failures. Example:

Ping failure: Server at <REDACTED:auth_host>:27017 reports wire version 6, but this version of libmongoc requires at least 7 (MongoDB 4.0)

DEVPROD-9029 tracks upgrading test servers. This PR proposes skipping tests in the short-term as they are expected to fail.

@kevinAlbs kevinAlbs requested a review from eramongodb July 25, 2024 19:23
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestion; otherwise, LGTM.

@@ -100,12 +100,15 @@ elif command -v otool >/dev/null; then
fi

if [[ "${ssl}" != "OFF" ]]; then
if true; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend using {} || {} instead of if/else to better distinguish the conditional blocks from existing code:

{
  # Skip 3.6. Remove this block when resolving CDRIVER-5645.
  echo "Skipping tests on server 3.6 (using 'auth_host' or 'auth_gssapi') until DEVPROD-9029 is addressed."
} || {
# FIXME: CDRIVER-2008 for the cygwin check
if [[ "${OSTYPE}" != "cygwin" ]]; then
  echo "Authenticating using X.509"
  ...
fi
}

@kevinAlbs kevinAlbs merged commit faabc9a into mongodb:master Jul 26, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants