CDRIVER-5669 improve string function handling of large strings #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clarify assert is intended guarantee cast is within bounds.
To check in case range of `size_t` is smaller than `uint32_t` (unlikely?)
Skip test by default. Large allocations fail on TSan tasks, and are slow on ASan tasks. Test may be used to verify behavior locally.
eramongodb
requested changes
Aug 12, 2024
rcsanchez97
approved these changes
Aug 12, 2024
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Roberto C. Sánchez <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
Co-authored-by: Ezra Chung <[email protected]>
eramongodb
approved these changes
Aug 12, 2024
kevinAlbs
added a commit
that referenced
this pull request
Aug 12, 2024
* add `bson_string_ensure_space` to check addition and casts. * add private `bson_next_power_of_two_u32` to avoid casts. * document length expectations * add test for maximum capacity of `bson_string_t` Skip test by default. Large allocations fail on TSan tasks, and are slow on ASan tasks. Test may be used to verify behavior locally. --------- Co-authored-by: Ezra Chung <[email protected]> Co-authored-by: Roberto C. Sánchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CDRIVER-5669 for a detailed description of the issue. Verified by this patch build.
Additional improvements:
bson_string_tfunctions.bson_next_power_of_two_u32to avoid casts betweenuint32_tandsize_t.