CDRIVER-4656 check if server is running with TLS in tests #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
force-pushed
the
fix-test.CDRIVER-4656
branch
from
cefb1ba to
f94a316
Compare
vector-of-bool
approved these changes
Aug 15, 2024
| @@ -2224,6 +2224,12 @@ test_client_buildinfo_hang (void) | |||
| static void | |||
| test_mongoc_client_change_openssl_ctx_before_ops (void) | |||
| { | |||
| if (!test_framework_get_ssl ()) { | |||
There was a problem hiding this comment.
Add @ctest-skipped@@ somewhere in message, which CTest will scan for and consider the test skipped if it sees it.
There was a problem hiding this comment.
Updated to use a skip function in TestSuite_AddFull. This results in printing @@ctest-skipped@@ on skip.
And skip test using skip function in `TestSuite_AddFull`. Tells CTest that the test was skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1673. Fixes failing
retry-true-latest-servertask. Example failure:Tests require the server to be running with TLS enabled. The
retry-true-latest-serveruses a C driver built with OpenSSL, but does not run against a server with TLS enabled.Verified with this patch.