CDRIVER-5739 do not warn if TXT authSource is ignored
#1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
authSource is ignoredauthSource is ignored
rcsanchez97
approved these changes
Sep 26, 2024
kevinAlbs
added a commit
that referenced
this pull request
Oct 1, 2024
* only trace if `authSource` is ignored from TXT record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not log a warning if TXT option
authSourceis ignored due to already being present in the URI.Background & Motivation
When using the
mongodb+srvprotocol, TXT records may provide defaults for URI options. From Initial DNS Seedlist Discovery:The auth mechanism
MONGODB-X509requiresauthSource=$external. MongoDB Atlas includes a default TXT recordauthSource=admin. This caused an unavoidable warning noted in CDRIVER-5712 when attempting to useMONGODB-X509to an Atlas M10 cluster:Since
authSourcehas a use-case to override, this PR downgrades the message to an informative trace log.