CDRIVER-5754 always write output on error in bson_validate_with_error_and_offset #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 11, 2024 17:22
the implementation fails to write its out parameters when an error occurs at the first byte, which can happen if the header is truncated.
ghost
requested a review
from 
kevinAlbs
approved these changes
Oct 15, 2024
Co-authored-by: Kevin Albertson <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Oct 15, 2024
…_and_offset (#1767) * bson_validate_with_error_and_offset: write outputs when err_offset==0 * regression test, test_bson_validate_with_error_and_offset --------- Co-authored-by: Kevin Albertson <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case in
bson_validate_with_error_and_offsetthat would cause unexpectedly uninitialized output parameters when a failure occurs at offset zero.Includes the test case from CDRIVER-5754, now passing.