CDRIVER-5702 rename and relocate common headers #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bson-dsl.h` is not part of libbson.
Intended to separate source files from (eventual) tests.
eramongodb
approved these changes
Oct 15, 2024
Co-authored-by: Ezra Chung <[email protected]>
ghost
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1762 and #1745.
Update headers in
src/commonfor consistency:mcd-string.htocommon-string-private.h. Rename symbolsmcd_string_*tomcommon_string_*.bson-dsl.htocommon-bson-dsl-private.h. Symbols are not renamed (e.g.bsonParseis not renamed).Split the
src/commondirectory into two subdirectories:src/common/srcandsrc/common/tests. This is intended to group test files forcommonand to ease selecting non-test source files (libbson recursively globs).Update macro guards in common headers for consistency (e.g.
COMMON_B64_PRIVATE_HtoMONGO_C_DRIVER_COMMON_B64_PRIVATE_H).Verified with this patch build: https://spruce.mongodb.com/version/670d7563d37beb0007386898