Skip to content

Update NEWS and release step after 1.29.0 release #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Nov 6, 2024

Summary

  • Update NEWS
  • Fix referenced branch for --sbom_branch
  • Remove "Notify the PHP Driver Team" step

Background & Motivation

I expect the --sbom_branch in the release step to be master for a minor release. During the 1.29.0 release, running the +signed-release/dist target with --sbom_branch=r1.29 resulted in an HTTP 404:

+sbom-download | 2024-11-06T19:46:57.028494Z [error    ] Message get_asset_group failed [silk_api] content=b'{"detail":"The manual ingested asset with id `mongo-c-driver-r1.29` was not found"}' filename=silk_api.py func_name=_check_response headers=Headers({'date': 'Wed, 06 Nov 2024 19:46:56 GMT', 'content-type': 'application/json', 'content-length': '83', 'connection': 'keep-alive', 'server': 'uvicorn', 'x-cid': 'e9eb4d70-5cac-4d19-9b8d-08a0945e02a8', 'x-ratelimit-limit': '10', 'x-ratelimit-remaining': '9', 'x-ratelimit-reset': '1730922418', 'x-ratelimit-retryafter': '0'}) lineno=142 module=silk_api parsed=None status_code=<HTTPStatus.NOT_FOUND: 404>

This reminded me that the Silk asset group for a branch is expected to be created in Evergreen.

I expect the "Notify the PHP Driver Team" step is redundant. The PHP driver tests with the master branch of the C driver.

For a minor release, download the augmented SBOM from the Silk asset group for the master branch.
The Silk asset group for the new release branch is created later in Evergreen.
The PHP driver tests with a master branch of the C driver. I expect this is redundant.
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 7cbbf2c into mongodb:master Nov 12, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants