CDRIVER-5770 Convert retryable write command construction prose tests to spec tests #1800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves CDRIVER-5770. Adds new retryable writes spec tests. Includes fixes to the unified test runner needed to pass tests.
DRIVERS-943 converts "Command Construction" tests into unified spec tests. The original "Command Construction" tests added in SPEC-969 were not implemented in the C driver.
Use single mongos to insert
initialData
Fixes an observed test failure:
This matches spec recommendation:
Use primary read preference to disable failpoints
Fixes an observed test failure inserting initial data:
The failure appears due to using primaryPreferred read preference to disable failpoints. A previous test marked the primary server Unknown, then disabled the failpoint on a secondary instead of the primary. Failpoints are expected to be configured with primary read preference:
Additional fixes
bson_destroy
ofbson_t
created withtmp_bson
.