Skip to content

CDRIVER-5644 increase wait time #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

kevinAlbs
Copy link
Collaborator

@kevinAlbs kevinAlbs commented Dec 4, 2024

Summary

Follow-up to #1779:

  • Increase the wait time to fix DEK cache tests on Windows.
  • Document expiration time of 0 means "never expire".

Verified with this patch build.

Background & Motivation

Tests failures were observed on Windows (example):

running test: decrypt, wait, and decrypt again
[...]
error: expected: 2 events but got 1

The test configures a 1ms expiration time. The failure suggests the DEK was not considered expired after the 2ms wait. This appears to be due to the coarse resolution of bson_get_monotonic_time on Windows: CDRIVER-4526. bson_get_montonic_time is used to check the current time. Pending resolution of CDRIVER-4526, the test is updated to increase the wait time.

@kevinAlbs kevinAlbs marked this pull request as ready for review December 4, 2024 14:48
@kevinAlbs kevinAlbs requested a review from adriandole December 4, 2024 14:48
@kevinAlbs kevinAlbs merged commit c3603b7 into mongodb:master Dec 4, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants