CDRIVER-5816: mongoc_bulkwrite_new and mongoc_bulkwrite_set_client #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Dec 4, 2024
| test_bulkwrite_execute_requires_client, | ||
| NULL /* dtor */, | ||
| NULL /* ctx */, | ||
| test_framework_skip_if_max_wire_version_less_than_25, // require server 8.0 |
There was a problem hiding this comment.
Suggested change
| test_framework_skip_if_max_wire_version_less_than_25, // require server 8.0 | |
| test_framework_skip_if_max_wire_version_less_than_25 // require server 8.0 |
Remove trailing comma to fix error:
../../../src/libmongoc/tests/test-mongoc-bulkwrite.c:718:4: error: expected expression
TestSuite_AddFull (suite,
^
There was a problem hiding this comment.
Sorry for not making this a draft PR. I was actually relying on Evergreen to build it since it was difficult to do so directly from my submodule (as opposed to #1803, which I did through a separate fork).
jmikola
force-pushed
the
cdriver-5816
branch
3 times, most recently
from
1cb53cd to
c43ff8a
Compare
kevinAlbs
approved these changes
Dec 5, 2024
jmikola
commented
Dec 6, 2024
| @@ -1438,12 +1445,36 @@ _bulkwritereturn_apply_result (mongoc_bulkwritereturn_t *self, | |||
| return true; | |||
| } | |||
|
|
|||
| void | |||
There was a problem hiding this comment.
Just removed the MONGOC_EXPORT here per #1806 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/CDRIVER-5816
https://jira.mongodb.org/browse/CDRIVER-5817
Using this to POC the PHPC implementation in PHPC-2478, so there is no rush to review/merge.